Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterhelper] Fix persistent queue size backup on reads #9740

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

carsonip
Copy link
Contributor

Description:

Persistent queue size backup on reads should depend on readIndex, not
writeIndex.

Persistent queue size backup on reads should depend on readIndex, not
writeIndex.
@carsonip carsonip marked this pull request as ready for review March 11, 2024 15:54
@carsonip carsonip requested review from a team and dmitryax March 11, 2024 15:54
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (b11588a) to head (0c25254).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9740   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         349      349           
  Lines       18572    18572           
=======================================
  Hits        16897    16897           
  Misses       1348     1348           
  Partials      327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carsonip nice find. Can you add a test that covers this situation?

@dmitryax
Copy link
Member

Thank you!

@TylerHelmuth a test to catch this might be too complicated. Given that this code path covers a very narrow edge case and is only beneficial for use cases when the collector is killed, I think it's ok to merge as is

@dmitryax dmitryax merged commit bc4ebbb into open-telemetry:main Mar 12, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 12, 2024
tomasmota pushed a commit to tomasmota/opentelemetry-collector that referenced this pull request Mar 14, 2024
…metry#9740)

**Description:** 

Persistent queue size backup on reads should depend on readIndex, not
writeIndex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants