Remove deprecated obsreport/obsreporttest package #9724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
remove-obsreport
branch
from
fccb64f to
d32af52
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9724 +/- ##
==========================================
+ Coverage 90.92% 90.94% +0.01%
==========================================
Files 348 347 -1
Lines 18401 18397 -4
==========================================
Hits 16732 16732
+ Misses 1346 1342 -4
Partials 323 323 ☔ View full report in Codecov by Sentry. |
atoulme
approved these changes
Mar 9, 2024
codeboten
approved these changes
Mar 11, 2024
tomasmota
pushed a commit
to tomasmota/opentelemetry-collector
that referenced
this pull request
Mar 14, 2024
All API in the package was deprecated in 0.93.0
jmacd
pushed a commit
to open-telemetry/otel-arrow
that referenced
this pull request
Mar 26, 2024
Remove a deprecated package that is removed completely from collector `v0.97.0` (open-telemetry/opentelemetry-collector#9724). This seems to be blocking a collector upgrade. Attempt to upgrade collector to v0.97.0 results in ``` go: found github.com/open-telemetry/otel-arrow/collector/receiver/filereceiver in github.com/open-telemetry/otel-arrow/collector/receiver/filereceiver v0.18.0 go: found github.com/open-telemetry/otel-arrow/collector/receiver/otelarrowreceiver in github.com/open-telemetry/otel-arrow/collector/receiver/otelarrowreceiver v0.18.0 go: finding module for package go.opentelemetry.io/collector/obsreport/obsreporttest go: github.com/open-telemetry/otel-arrow/collector/cmd/otelarrowcol imports github.com/open-telemetry/otel-arrow/collector/receiver/otelarrowreceiver tested by github.com/open-telemetry/otel-arrow/collector/receiver/otelarrowreceiver.test imports go.opentelemetry.io/collector/obsreport/obsreporttest: module go.opentelemetry.io/collector@latest found (v0.97.0), but does not contain package go.opentelemetry.io/collector/obsreport/obsreporttest ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All API in the package was deprecated in 0.93.0