remove year from copyright #964

bruno-garcia · 2020-05-13T18:20:13Z

This came up in code reviews now on an exporter for Sentry but also in other OTel repos:

james-bebbington · 2020-05-14T02:53:45Z

I'm not really sure of the implications of removing the year from this disclaimer, but if its deemed okay, note that you've only updated a small number of source files in this PR (many files reference 2018, 2019, or include an extra comma after the year). If we're going to make this change, we should presumably update everything at once.

bruno-garcia · 2020-05-14T13:03:34Z

Good catch, Thanks I'll update the others

bruno-garcia · 2020-05-14T14:09:25Z

@james-bebbington should be fixed now. Thanks for reviewing.

/cc @reyang @SergeyKanzhelev who are tagged in the screenshot I added to the PR.

reyang

LGTM.

tigrannajaryan · 2020-05-19T21:10:38Z

Makefile

@@ -81,7 +81,7 @@ test-with-cover:

 .PHONY: addlicense
 addlicense:
-	$(ADDLICENCESE) -y '' -c 'OpenTelemetry Authors' $(ALL_SRC)
+	$(ADDLICENCESE) -c 'The OpenTelemetry Authors' $(ALL_SRC)


Do we need "The"?

Just trying to be consistent with the other repos but I'd be happy to drop it.

tigrannajaryan · 2020-05-19T21:11:06Z

@bruno-garcia please fix the merge conflict.

bruno-garcia · 2020-05-19T22:02:59Z

@tigrannajaryan fixed. Thanks

bruno-garcia · 2020-05-20T00:30:24Z

CI is failing on loadtests:

With:
Error: No such image: cimg/go:1.14

I'll try to trigger it again by reopening this PR

bruno-garcia · 2020-05-20T00:32:41Z

That didn't do it.
I can't re-run it on CircleCI because:

Can anyone bail me out here please?

jrcamp · 2020-05-20T15:14:30Z

I trigger it by doing a commit --amend to my previous change and force push.

…ector into ref/copyright-year

codecov · 2020-05-20T17:50:16Z

Codecov Report

Merging #964 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         189      189           
  Lines       13167    13167           
=======================================
  Hits        11273    11273           
  Misses       1441     1441           
  Partials      453      453

Impacted Files	Coverage Δ
client/client.go	`100.00% <ø> (ø)`
component/componenterror/errors.go	`100.00% <ø> (ø)`
component/componenttest/error_waiting_host.go	`64.70% <ø> (ø)`
component/componenttest/nop_host.go	`33.33% <ø> (ø)`
config/config.go	`99.70% <ø> (ø)`
config/configcheck/configcheck.go	`100.00% <ø> (ø)`
config/configgrpc/configgrpc.go	`100.00% <ø> (ø)`
config/configmodels/configmodels.go	`100.00% <ø> (ø)`
config/configtest/configtest.go	`100.00% <ø> (ø)`
config/configtls/configtls.go	`100.00% <ø> (ø)`
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf2fc7...78b75c5. Read the comment docs.

bruno-garcia · 2020-05-20T17:55:20Z

CI is happy now.

tigrannajaryan · 2020-05-22T13:19:20Z

@bruno-garcia can you rebase or otherwise make a change to the commit to trigger a build again? For some reason codecov is stuck.

…ector into ref/copyright-year

bruno-garcia · 2020-05-22T21:06:57Z

@tigrannajaryan I've pulled master into the branch and did another pass. Mainly hostmetricsreceiver that was added and included year.

bruno-garcia · 2020-05-22T21:25:04Z

@tigrannajaryan CI seems to be happy all the way now, including codecov \o/

…g data to Splunk Enterprise (open-telemetry#964)

…etry#1310)

… quoted issue. (open-telemetry#1347) * test: Add CI scenarios for eBPF Chart. open-telemetry#964 Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * fix: EBPF_NET_CRASH_METRIC_PORT env in ebpf chart not being quoted issue. Signed-off-by: Yang, Robin <[email protected]> * fix: EBPF_NET_CRASH_METRIC_PORT env in ebpf chart not being quoted issue. Signed-off-by: Yang, Robin <[email protected]> --------- Signed-off-by: Yang, Robin <[email protected]>

…ry#1346) * test: Add CI scenarios for eBPF Chart. open-telemetry#964 Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * test: Add CI scenarios for eBPF Chart. [issue-964] Signed-off-by: Yang, Robin <[email protected]> * fix: EBPF_NET_CRASH_METRIC_PORT env in ebpf chart not being quoted issue. Signed-off-by: Yang, Robin <[email protected]> * feat: grant ebpf k8s collector job watching permission. Signed-off-by: Yang, Robin <[email protected]> * feat: grant ebpf k8s collector job watching permission. Signed-off-by: Yang, Robin <[email protected]> * feat: grant ebpf k8s collector job watching permission. Signed-off-by: Yang, Robin <[email protected]> --------- Signed-off-by: Yang, Robin <[email protected]>

remove year from copyright

51a4730

bruno-garcia requested review from bogdandrutu, dmitryax, flands, owais, pjanotti, rghetia, songy23 and tigrannajaryan as code owners May 13, 2020 18:20

bruno-garcia mentioned this pull request May 13, 2020

feat: Create sentry exporter file structure getsentry/opentelemetry-collector-contrib#2

Merged

bruno-garcia added 2 commits May 14, 2020 10:57

remove year from license files

ebee203

remove double slash

07b60fd

reyang approved these changes May 17, 2020

View reviewed changes

tigrannajaryan reviewed May 19, 2020

View reviewed changes

Merge branch 'master' into ref/copyright-year

46df80e

bruno-garcia closed this May 20, 2020

bruno-garcia reopened this May 20, 2020

Merge branch 'master' of github.com:open-telemetry/opentelemetry-coll…

2205e1f

…ector into ref/copyright-year

tigrannajaryan self-assigned this May 20, 2020

bogdandrutu approved these changes May 21, 2020

View reviewed changes

bruno-garcia added 2 commits May 22, 2020 17:28

Merge branch 'master' of github.com:open-telemetry/opentelemetry-coll…

676c0ba

…ector into ref/copyright-year

drop year

78b75c5

tigrannajaryan merged commit 8aa2731 into open-telemetry:master May 26, 2020

wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020

Remove year from copyright (open-telemetry#964)

30ed73a

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023

Add an example showing how to use filelog with otel collector, sendin…

a75dc4a

…g data to Splunk Enterprise (open-telemetry#964)

Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024

Remove unused public API to_span_ptr (open-telemetry#964)

c7d6409

swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024

test: Add CI scenarios for eBPF Chart. open-telemetry#964 (open-telem…

7f64f3f

…etry#1310)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove year from copyright #964

remove year from copyright #964

bruno-garcia commented May 13, 2020

james-bebbington commented May 14, 2020

bruno-garcia commented May 14, 2020

bruno-garcia commented May 14, 2020

reyang left a comment

tigrannajaryan May 19, 2020

bruno-garcia May 19, 2020

tigrannajaryan commented May 19, 2020

bruno-garcia commented May 19, 2020

bruno-garcia commented May 20, 2020

bruno-garcia commented May 20, 2020

jrcamp commented May 20, 2020

codecov bot commented May 20, 2020 •

edited

Loading

bruno-garcia commented May 20, 2020

tigrannajaryan commented May 22, 2020

bruno-garcia commented May 22, 2020

bruno-garcia commented May 22, 2020

remove year from copyright #964

remove year from copyright #964

Conversation

bruno-garcia commented May 13, 2020

james-bebbington commented May 14, 2020

bruno-garcia commented May 14, 2020

bruno-garcia commented May 14, 2020

reyang left a comment

Choose a reason for hiding this comment

tigrannajaryan May 19, 2020

Choose a reason for hiding this comment

bruno-garcia May 19, 2020

Choose a reason for hiding this comment

tigrannajaryan commented May 19, 2020

bruno-garcia commented May 19, 2020

bruno-garcia commented May 20, 2020

bruno-garcia commented May 20, 2020

jrcamp commented May 20, 2020

codecov bot commented May 20, 2020 • edited Loading

Codecov Report

bruno-garcia commented May 20, 2020

tigrannajaryan commented May 22, 2020

bruno-garcia commented May 22, 2020

bruno-garcia commented May 22, 2020

codecov bot commented May 20, 2020 •

edited

Loading