Add workaround for data race in TestApplication_StartUnified #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a Sleep to work around a data race bug in Jaeger (jaegertracing/jaeger#1625) caused by stopping immediately after starting. Without this Sleep we were observing this bug on our side: open-telemetry#43 The Sleep ensures that Jaeger Start() is fully completed before we call Jaeger Stop(). TODO: Jaeger bug is already fixed, remove this once we update Jaeger to latest version. Testing done: make test
tigrannajaryan
requested review from
bogdandrutu,
flands,
pjanotti and
songy23
as code owners
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 69.75% 69.75%
=======================================
Files 101 101
Lines 6395 6395
=======================================
Hits 4461 4461
Misses 1699 1699
Partials 235 235Continue to review full report at Codecov.
|
pjanotti
approved these changes
Jul 3, 2019
owais
approved these changes
Jul 3, 2019
songy23
approved these changes
Jul 3, 2019
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…ry#96) * add exported value for traceOptionBitMaskUnused (for testing) * move key_test to package core_test * add span_context_test to package core_test
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Clean up getting started docs We continue to add getting started documentation as support for different platforms increases and as installation scripts are introduced. Instead of continuing to grow the main README, create getting started docs and link to them. Also add supported component information to main README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Sleep to work around a data race bug in Jaeger
(jaegertracing/jaeger#1625) caused
by stopping immediately after starting.
Without this Sleep we were observing this bug on our side:
#43
The Sleep ensures that Jaeger Start() is fully completed before
we call Jaeger Stop().
TODO: Jaeger bug is already fixed, remove this once we update Jaeger
to latest version.
Testing done: make test