Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] produce scope name with full url #9556

Merged

Conversation

codeboten
Copy link
Contributor

This is part of #9494

@codeboten codeboten requested review from a team and dmitryax February 12, 2024 23:30
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (70c2c4b) 90.58% compared to head (9a5c621) 90.59%.

Files Patch % Lines
cmd/mdatagen/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...ardconnector/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...ebugexporter/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...gingexporter/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...otlpexporter/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...httpexporter/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...astextension/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...terextension/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...gesextension/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
...tchprocessor/internal/metadata/generated_status.go 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9556   +/-   ##
=======================================
  Coverage   90.58%   90.59%           
=======================================
  Files         347      347           
  Lines       18244    18235    -9     
=======================================
- Hits        16527    16520    -7     
+ Misses       1388     1385    -3     
- Partials      329      330    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

Can you please add a changelog?

@codeboten
Copy link
Contributor Author

@dmitryax changelog has been added

codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Feb 13, 2024
This follows open-telemetry#9556 and uses the Meter func instead of managing the scope in the batch processor manually

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this pull request Feb 13, 2024
@codeboten codeboten merged commit aa76482 into open-telemetry:main Feb 14, 2024
45 of 46 checks passed
@codeboten codeboten deleted the codeboten/consisten-scope-name branch February 14, 2024 15:50
@github-actions github-actions bot added this to the next release milestone Feb 14, 2024
codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request Mar 1, 2024
This follows open-telemetry#9556 and uses the Meter func instead of managing the scope in the batch processor manually. Replaces open-telemetry#9581

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this pull request Mar 1, 2024
codeboten added a commit that referenced this pull request Mar 11, 2024
This follows #9556 and uses the Meter func instead of managing the scope
in the batch processor manually. Replaces #9581

Signed-off-by: Alex Boten <[email protected]>
tomasmota pushed a commit to tomasmota/opentelemetry-collector that referenced this pull request Mar 14, 2024
This follows open-telemetry#9556 and uses the Meter func instead of managing the scope
in the batch processor manually. Replaces open-telemetry#9581

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants