[component] Remove host.ReportFatalError #9506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9506 +/- ##
==========================================
- Coverage 90.37% 90.36% -0.02%
==========================================
Files 346 346
Lines 18194 18191 -3
==========================================
- Hits 16443 16438 -5
- Misses 1418 1419 +1
- Partials 333 334 +1 ☔ View full report in Codecov by Sentry. |
mx-psi
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Looks like there is an extension still using it
# github.com/open-telemetry/opentelemetry-collector-contrib/extension/awsproxy [github.com/open-telemetry/opentelemetry-collector-contrib/extension/awsproxy.test]
Error: ./extension.go:29:9: host.ReportFatalError undefined (type component.Host has no field or method ReportFatalError)
mx-psi
reviewed
Feb 7, 2024
Co-authored-by: Pablo Baeyens <[email protected]>
|
I have opened open-telemetry/opentelemetry-collector-contrib#31104 to fix the contrib tests. |
mx-psi
added
needed-for-1.0
release:required-for-ga
|
open-telemetry/opentelemetry-collector-contrib#31134 is open to fix this now. |
|
Merged! Re-rolling the CI dice.... 🎲 |
bogdandrutu
approved these changes
Feb 8, 2024
|
@atoulme not yet fixed contrib. |
|
Remaining PRs: open-telemetry/opentelemetry-collector-contrib#31145 and open-telemetry/opentelemetry-collector-contrib#31146 |
mx-psi
approved these changes
Feb 9, 2024
maxious
added a commit
to Canva/trace2receiver
that referenced
this pull request
Feb 28, 2024
open-telemetry/opentelemetry-collector#9506 removed deprecated codepath for fatal errors in reciever setup so need to replace to have compatibility with newer otel
jeffhostetler
added a commit
to git-ecosystem/trace2receiver
that referenced
this pull request
Mar 6, 2024
host.ReportFatalError() was deprecated and removed. Update Windows named pipe startup code to use ReportStatus() instead. open-telemetry/opentelemetry-collector#6344 open-telemetry/opentelemetry-collector#9506 Signed-off-by: Jeff Hostetler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove
host.ReportFatalError. It has been deprecated since 0.87.0.Link to tracking Issue:
#6344