[config/configretry] Allow zero multiplier and arbitrary randomization factor

.chloggen/mx-psi_configretry.yaml

@@ -0,0 +1,26 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: configretry
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Validate that time.Duration and multiplier values in configretry are non-negative.
+
+# One or more tracking issues or pull requests related to the change
+issues: [9091]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: | 
+  These values were previously accepted and lead to unspecified behavior.
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []

config/configretry/backoff.go

@@ -49,11 +49,8 @@ func (bs *BackOffConfig) Validate() error {
 	if bs.InitialInterval < 0 {
 		return errors.New("'initial_interval' must be non-negative")
 	}
-	if bs.RandomizationFactor < 0 || bs.RandomizationFactor > 1 {
-		return errors.New("'randomization_factor' must be within [0, 1]")
-	}
-	if bs.Multiplier <= 0 {
-		return errors.New("'multiplier' must be positive")
+	if bs.Multiplier < 0 {
+		return errors.New("'multiplier' must be non-negative")
 	}
 	if bs.MaxInterval < 0 {
 		return errors.New("'max_interval' must be non-negative")

config/configretry/backoff_test.go

@@ -31,20 +31,18 @@ func TestInvalidInitialInterval(t *testing.T) {
 	assert.Error(t, cfg.Validate())
 }
 
-func TestInvalidRandomizationFactor(t *testing.T) {
+func TestInvalidMultiplier(t *testing.T) {
 	cfg := NewDefaultBackOffConfig()
 	assert.NoError(t, cfg.Validate())
-	cfg.RandomizationFactor = -1
-	assert.Error(t, cfg.Validate())
-	cfg.RandomizationFactor = 2
+	cfg.Multiplier = -1
 	assert.Error(t, cfg.Validate())
 }
 
-func TestInvalidMultiplier(t *testing.T) {
+func TestZeroMultiplierIsValid(t *testing.T) {
 	cfg := NewDefaultBackOffConfig()
 	assert.NoError(t, cfg.Validate())
 	cfg.Multiplier = 0
-	assert.Error(t, cfg.Validate())
+	assert.NoError(t, cfg.Validate())
 }
 
 func TestInvalidMaxInterval(t *testing.T) {