[chore] apply fieldalignment linter

[atoulme]

Fixes #2789

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58744cd) 91.47% compared to head (917efe3) 91.47%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9133   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         320      320           
  Lines       17187    17187           
=======================================
  Hits        15722    15722           
  Misses       1165     1165           
  Partials      300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codeboten]

Pinging @mx-psi on this as he tried this originally and had some comments around the readability of the code w/ this linter enabled

[mx-psi]

We should at least exclude the test files, there's not much of a point there in terms of perf improvements.

IMO it does hinder readability in structs like the ones on confighttp and configgrpc, where I would expect that the Endpoint/Address comes first in the struct. It also does not seem to be very beneficial there. See also the other issues I pointed out on #2789 (comment)

Maybe we can start with enabling it just for internal packages? That seems like a good way to get started trying this out without worsening readability of the public API

[atoulme]

I can take slices of this PR and apply them selectively to the codebase to follow the pattern your recommend as separate PRs. It will make review easier.

[atoulme]

Closing as this won't land as is.