[pdata] Document that Marshalers/Unmarshalers use OTLP/JSON format explicitly #8974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
added
Skip Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8974 +/- ##
==========================================
+ Coverage 91.53% 91.55% +0.01%
==========================================
Files 316 316
Lines 17111 17111
==========================================
+ Hits 15663 15666 +3
+ Misses 1152 1150 -2
+ Partials 296 295 -1 ☔ View full report in Codecov by Sentry. |
atoulme
approved these changes
Nov 21, 2023
codeboten
approved these changes
Nov 21, 2023
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…plicitly (open-telemetry#8974) Explicitly documents that the `JSONMarshaler` and `JSONUnmarshaler` as conforming to the format in the OTLP/JSON specification. The intent is to be explicit that we follow this spec and that deviations (such as supporting snake case) are bugs that can be removed in a minor version update. **Link to tracking Issue:** Relates to open-telemetry#6287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Explicitly documents that the
JSONMarshalerandJSONUnmarshaleras conforming to the format in the OTLP/JSON specification.The intent is to be explicit that we follow this spec and that deviations (such as supporting snake case) are bugs that can be removed in a minor version update.
Link to tracking Issue: Relates to #6287