[chore] [cmd/builder] Require github.com/knadh/koanf submodules #8301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly require github.com/knadh/koanf/maps and github.com/knadh/koanf/providers/confmap to workaround ambiguous imports. Otherwise, the command fails with: ``` Error: failed to update go.mod: exit status 1. Output: go: github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontribcol imports github.com/open-telemetry/opentelemetry-collector-contrib/connector/countconnector imports go.opentelemetry.io/collector/confmap imports github.com/knadh/koanf/maps: ambiguous import: found package github.com/knadh/koanf/maps in multiple modules: github.com/knadh/koanf v1.5.0 (/Users/danoshin/go/pkg/mod/github.com/knadh/[email protected]/maps) github.com/knadh/koanf/maps v0.1.1 (/Users/danoshin/go/pkg/mod/github.com/knadh/koanf/[email protected]) go: github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontribcol imports github.com/open-telemetry/opentelemetry-collector-contrib/connector/countconnector imports go.opentelemetry.io/collector/confmap imports github.com/knadh/koanf/providers/confmap: ambiguous import: found package github.com/knadh/koanf/providers/confmap in multiple modules: github.com/knadh/koanf v1.5.0 (/Users/danoshin/go/pkg/mod/github.com/knadh/[email protected]/providers/confmap) github.com/knadh/koanf/providers/confmap v0.1.0 (/Users/danoshin/go/pkg/mod/github.com/knadh/koanf/providers/[email protected]) make: *** [genotelcontribcol] Error 1 ```
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8301 +/- ##
==========================================
+ Coverage 90.22% 90.38% +0.15%
==========================================
Files 302 303 +1
Lines 15859 15904 +45
==========================================
+ Hits 14309 14375 +66
+ Misses 1256 1235 -21
Partials 294 294
☔ View full report in Codecov by Sentry. |
codeboten
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly require
github.com/knadh/koanf/mapsandgithub.aaakk.us.kg/knadh/koanf/providers/confmapin go.mod to workaround ambiguous imports. Otherwise, the command fails with: