Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove dependency references to koanf v1 #8219

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Aug 10, 2023

Description:

github.com/knadh/koanf/maps and other koanf packages can be ambiguously loaded from their own modules or from github.com/knadh/koanf v.1.x when using Go workspaces. This PR removes references to any koanf v1 packages to disambiguate the import path.

Link to tracking Issue: #8127

I realize this change is enormous, I wasn't able to figure out how to isolate the change to just the koanf packages. Any recommendations welcome.

I produced these changes by running the following:

go mod edit -exclude=github.com/knadh/[email protected]
go work init
go work use -r .
go work sync
make gotidy
make genotelcorecol

@evan-bradley evan-bradley requested review from a team and jpkrohling August 10, 2023 21:04
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b479a52) 90.27% compared to head (4cfc301) 90.27%.

❗ Current head 4cfc301 differs from pull request most recent head 497b930. Consider uploading reports for the commit 497b930 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8219   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         301      301           
  Lines       15596    15596           
=======================================
  Hits        14080    14080           
  Misses       1227     1227           
  Partials      289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

@codeboten
Copy link
Contributor

Please rebase to pick up the updates to CI to test go 1.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants