[receiver/otlpreceiver] improve request's content-type check #7451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This will also need a changelog entry, there's a guide on how to add one here.
evan-bradley
approved these changes
Mar 31, 2023
.chloggen/otlpreceiver_support_content-type_with_parameters.yaml
Outdated
Show resolved
Hide resolved
codeboten
approved these changes
Mar 31, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7451 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 292 292
Lines 14205 14210 +5
=======================================
+ Hits 12943 12948 +5
Misses 996 996
Partials 266 266
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
content-type header could contain optional parameters after the mime-type, do not reject requests in this case
atoulme
added
the
ready-to-merge
codeboten
approved these changes
Apr 27, 2023
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 2, 2023
…lemetry#7451) content-type header could contain optional parameters after the mime-type, do not reject requests in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content-type header could contain optional parameters after the mime-type, do not reject requests in this case
note: this is my first PR in this repo, excuse me if I miss something and guide me on moving forward, thanks!
Description:
If the HTTP request contains a valid content-type header in the form
application/json; charset=utf-8the receiver replies with415 unsupported media type, supported:.Also, by spec, header is case-insensitive, so we take care also of this.
Link to tracking Issue:
Fixes #7452
Testing:
Added unit tests to verify the bug and see that the change fixes it