Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Prepare release 0.71.0/1.0.0-rc5 #7139

Closed
wants to merge 7 commits into from

Conversation

opentelemetrybot
Copy link
Contributor

The following commands were run to prepare this release:

  • make chlog-update VERSION=0.71.0/1.0.0-rc5
  • make prepare-release GH=none PREVIOUS_VERSION=1.0.0-rc4 RELEASE_CANDIDATE=1.0.0-rc5 MODSET=stable
  • make prepare-release GH=none PREVIOUS_VERSION=0.70.0 RELEASE_CANDIDATE=0.71.0 MODSET=beta

@opentelemetrybot opentelemetrybot requested review from a team and djaglowski February 6, 2023 17:51
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 90.84% // Head: 90.84% // No change to project coverage 👍

Coverage data is based on head (b03a79b) compared to base (6f69f62).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7139   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         293      293           
  Lines       14302    14302           
=======================================
  Hits        12993    12993           
  Misses       1041     1041           
  Partials      268      268           
Impacted Files Coverage Δ
cmd/builder/internal/builder/config.go 68.67% <ø> (ø)
cmd/otelcorecol/main.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -4,6 +4,52 @@

<!-- next version -->

## 1.0.0-rc5/0.71.0
Copy link
Member

@mx-psi mx-psi Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: format is different from log entry below (this one does not have a v)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, saw that too. See #7141

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think the above comment should be blocking, we can move forward with the release and fix it later if it's a changelog only thing

codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Feb 6, 2023
Fixes the issue identified in the comment: open-telemetry#7139 (comment)

Signed-off-by: Alex Boten <[email protected]>
bogdandrutu pushed a commit that referenced this pull request Feb 6, 2023
Fixes the issue identified in the comment: #7139 (comment)

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten closed this Feb 6, 2023
@codeboten codeboten deleted the prepare-release-prs/0.71.0-1.0.0-rc5 branch February 6, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants