Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update pcommon.Map.Equal deprecation doc string #6894

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jan 6, 2023

Map is not comparable type

@dmitryax dmitryax requested review from a team and Aneurysm9 January 6, 2023 01:55
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 91.05% // Head: 91.05% // No change to project coverage 👍

Coverage data is based on head (26e28a0) compared to base (1f3c5fb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6894   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files         237      237           
  Lines       14306    14306           
=======================================
  Hits        13027    13027           
  Misses       1027     1027           
  Partials      252      252           
Impacted Files Coverage Δ
pdata/pcommon/common.go 93.56% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten merged commit 39201f6 into open-telemetry:main Jan 6, 2023
@dmitryax dmitryax deleted the update-map-equal-deprecation-message branch January 26, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants