Remove deprecated pcommon.Value.Equal

[bogdandrutu]

No description provided.

[codecov]

Codecov Report

Base: 91.05% // Head: 91.14% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (4a47139) compared to base (7d168dd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6860      +/-   ##
==========================================
+ Coverage   91.05%   91.14%   +0.08%     
==========================================
  Files         237      237              
  Lines       14298    14362      +64     
==========================================
+ Hits        13019    13090      +71     
+ Misses       1027     1022       -5     
+ Partials      252      250       -2     

Impacted Files	Coverage Δ
pdata/pcommon/common.go	94.44% <ø> (+0.87%)	⬆️
connector/connector.go	100.00% <100.00%> (ø)
connector/connectortest/connector.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dmitryax]

It looks like it's actually being used for filtering in the contrib production code. Let me handle that first

[dmitryax]

@bogdandrutu I have the following PRs to remove the method usage from contrib:

• [processor/groupbyattr] Use hash of resource attributes for grouping opentelemetry-collector-contrib#17527 can be applied with performance improvement.
• [internal/filter] Replace usage of deprecated Value.Equal opentelemetry-collector-contrib#17521 doesn't provide any performance benefits.

I think open-telemetry/opentelemetry-collector-contrib#17521 proves that we probably need to keep Value.Equal method.