Draft changes to show how we can split component #6552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
This was referenced Nov 15, 2022
djaglowski
reviewed
Nov 22, 2022
| @@ -24,8 +24,7 @@ import ( | |||
| // ProcessorConfig is the configuration of a component.Processor. Specific Processor must implement | |||
| // this interface and must embed ProcessorSettings struct or a struct that extends it. | |||
| type ProcessorConfig interface { | |||
There was a problem hiding this comment.
Should this file be moved entirely to processor package?
| @@ -24,8 +24,7 @@ import ( | |||
| // ReceiverConfig is the configuration of a component.Receiver. Specific Extension must implement | |||
| // this interface and must embed ReceiverSettings struct or a struct that extends it. | |||
| type ReceiverConfig interface { | |||
There was a problem hiding this comment.
Move file to receiver package?
This was referenced Nov 22, 2022
Merged
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.