-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate obsreport.Must functions in favor of obsreport.New #6510
deprecate obsreport.Must functions in favor of obsreport.New #6510
Conversation
587de2f
to
d4aa834
Compare
d4aa834
to
1544a02
Compare
Codecov ReportBase: 91.66% // Head: 91.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6510 +/- ##
==========================================
- Coverage 91.66% 91.36% -0.30%
==========================================
Files 240 240
Lines 13815 13875 +60
==========================================
+ Hits 12663 12677 +14
- Misses 921 955 +34
- Partials 231 243 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@paivagustavo please prepare a PR in contrib to update for the new code. Use |
Co-authored-by: Bogdan Drutu <[email protected]>
Description: Deprecate
obsreport.Must*
functions, make deprecatedobsreport.New*
functions to return an error and undeprecate them.The
ScraperControllerReceiver
was changed to created aobsreport.Scraper
for each configured scraper during theNewScraperControllerReceiver
instead of creating a newobsreport.Scraper
every scrape.Link to tracking Issue: #6458