Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate obsreport.Must functions in favor of obsreport.New #6510

Conversation

paivagustavo
Copy link
Member

Description: Deprecate obsreport.Must* functions, make deprecated obsreport.New* functions to return an error and undeprecate them.

The ScraperControllerReceiver was changed to created a obsreport.Scraper for each configured scraper during the NewScraperControllerReceiver instead of creating a new obsreport.Scraper every scrape.

Link to tracking Issue: #6458

@paivagustavo paivagustavo requested review from a team and codeboten November 9, 2022 16:33
@paivagustavo paivagustavo force-pushed the gustavo/return_error_for_obsreport_new_functions branch from 587de2f to d4aa834 Compare November 9, 2022 16:40
@paivagustavo paivagustavo force-pushed the gustavo/return_error_for_obsreport_new_functions branch from d4aa834 to 1544a02 Compare November 9, 2022 16:48
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 91.66% // Head: 91.36% // Decreases project coverage by -0.29% ⚠️

Coverage data is based on head (0e19c73) compared to base (226dc13).
Patch coverage: 60.29% of modified lines in pull request are covered.

❗ Current head 0e19c73 differs from pull request most recent head f4ef94f. Consider uploading reports for the commit f4ef94f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6510      +/-   ##
==========================================
- Coverage   91.66%   91.36%   -0.30%     
==========================================
  Files         240      240              
  Lines       13815    13875      +60     
==========================================
+ Hits        12663    12677      +14     
- Misses        921      955      +34     
- Partials      231      243      +12     
Impacted Files Coverage Δ
obsreport/obsreport_processor.go 90.67% <28.57%> (-4.02%) ⬇️
obsreport/obsreport_scraper.go 89.58% <28.57%> (-10.42%) ⬇️
receiver/otlpreceiver/otlp.go 80.24% <40.00%> (-4.42%) ⬇️
exporter/exporterhelper/common.go 90.80% <57.14%> (-3.18%) ⬇️
exporter/exporterhelper/logs.go 80.64% <57.14%> (-4.11%) ⬇️
exporter/exporterhelper/metrics.go 80.64% <57.14%> (-4.11%) ⬇️
exporter/exporterhelper/obsreport.go 94.91% <57.14%> (-5.09%) ⬇️
exporter/exporterhelper/traces.go 80.95% <57.14%> (-4.05%) ⬇️
processor/memorylimiterprocessor/memorylimiter.go 89.63% <62.50%> (-1.37%) ⬇️
obsreport/obsreport_exporter.go 94.59% <66.66%> (+1.83%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.chloggen/return_error_for_obsreport_new_functions.yaml Outdated Show resolved Hide resolved
obsreport/obsreport_exporter.go Show resolved Hide resolved
obsreport/obsreport_receiver.go Show resolved Hide resolved
@bogdandrutu
Copy link
Member

@paivagustavo please prepare a PR in contrib to update for the new code. Use make update-otel in contrib repo to upgrade to latest merged PR.

@bogdandrutu bogdandrutu merged commit 20e3aac into open-telemetry:main Nov 10, 2022
@paivagustavo paivagustavo deleted the gustavo/return_error_for_obsreport_new_functions branch November 11, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants