Remove get from newly added funcs on Gate that don't conflict #6485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the conflict between the public member and func name, cannot do the same for ID/Description, will fix in a later version after we remove the public members. No need for deprecation, were added in this version. Signed-off-by: Bogdan <[email protected]>
Codecov ReportBase: 91.64% // Head: 91.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6485 +/- ##
==========================================
+ Coverage 91.64% 91.65% +0.01%
==========================================
Files 238 240 +2
Lines 13811 13817 +6
==========================================
+ Hits 12657 12664 +7
+ Misses 924 923 -1
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/cc @MovieStoreGuy |
MovieStoreGuy
approved these changes
Nov 7, 2022
mx-psi
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the conflict between the public member and func name, cannot do the same for ID/Description, will fix in a later version after we remove the public members.
No need for deprecation, they were added in this version.
/cc @mx-psi based on the discussion from #6447