Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert how the args are parsed on windows #6431

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Revert how the args are parsed on windows #6431

merged 1 commit into from
Oct 28, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Oct 28, 2022 •
edited
Loading

Fixes #6433

@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

Base: 91.41% // Head: 91.41% // No change to project coverage 👍

Coverage data is based on head (6ad11a1) compared to base (82787ad).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release/v0.63.x    #6431   +/-   ##
================================================
  Coverage            91.41%   91.41%           
================================================
  Files                  235      235           
  Lines                13473    13473           
================================================
  Hits                 12317    12317           
  Misses                 933      933           
  Partials               223      223

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu mentioned this pull request Oct 28, 2022
Closed
@bogdandrutu bogdandrutu marked this pull request as ready for review October 28, 2022 16:39
@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan October 28, 2022 16:39
@codeboten
Copy link
Contributor

Testing on windows confirms this addresses the issue, and that the service comes up

@codeboten codeboten changed the base branch from main to release/v0.63.x October 28, 2022 19:05
@codeboten codeboten merged commit 525b2c7 into open-telemetry:release/v0.63.x Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@codeboten codeboten codeboten approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run as Windows Service
3 participants
@bogdandrutu @codeboten @TylerHelmuth