[unrevert][config{grpc,http}] Add warning when using unspecified address #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…telemetry#6267) * [config/config{grpc,http}] Add warning when using a 0.0.0.0 endpoint * Add warning when using unspecified address * Add changelog entry * Fix tests * Fix HTTP tests * Apply suggestions from code review Co-authored-by: Alex Boten <[email protected]> * Use IsUnspecified method * no else after return * Move shared code to internal Co-authored-by: Alex Boten <[email protected]> (cherry picked from commit 396964d)
Codecov ReportBase: 91.75% // Head: 91.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6421 +/- ##
==========================================
+ Coverage 91.75% 91.77% +0.01%
==========================================
Files 237 238 +1
Lines 13638 13670 +32
==========================================
+ Hits 12514 12546 +32
Misses 893 893
Partials 231 231
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
reviewed
Oct 27, 2022
codeboten
approved these changes
Nov 2, 2022
Aneurysm9
approved these changes
Nov 2, 2022
codeboten
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: <Describe what has changed.
Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.>
Unrevert #6267 and make it so that we never error out.
Add support for
:and:<port>address typesLink to tracking Issue: Fixes #6406