Allow to configure sampling config for logs #6404
Conversation
Codecov ReportBase: 91.64% // Head: 91.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6404 +/- ##
==========================================
- Coverage 91.64% 91.63% -0.01%
==========================================
Files 238 240 +2
Lines 13811 13826 +15
==========================================
+ Hits 12657 12670 +13
- Misses 924 925 +1
- Partials 230 231 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| // LogsSamplingConfig sets a sampling strategy for the logger. Sampling caps the | ||
| // global CPU and I/O load that logging puts on your process while attempting | ||
| // to preserve a representative subset of your logs. | ||
| type LogsSamplingConfig struct { |
There was a problem hiding this comment.
Is it worth adding a note in the troubleshooting docs as to how to enable sampling? https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/troubleshooting.md#logs
There was a problem hiding this comment.
We have only minimal examples there, not sure if we should add all of them there, or keep it minimal only the level.
There was a problem hiding this comment.
We can do it in a separate PR.
Fixes open-telemetry#4554 Signed-off-by: Bogdan <[email protected]>
bogdandrutu
force-pushed
the
allowsampling
branch
from
8fccc4a to
276c1c9
Compare
Fixes #4554