Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using deprecated config.Config in servicetest #6393

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 24, 2022
@bogdandrutu bogdandrutu requested review from a team and codeboten October 24, 2022 23:32
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 91.79% // Head: 91.77% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e7a4334) compared to base (9a43339).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6393      +/-   ##
==========================================
- Coverage   91.79%   91.77%   -0.02%     
==========================================
  Files         235      235              
  Lines       13452    13464      +12     
==========================================
+ Hits        12348    12357       +9     
- Misses        876      878       +2     
- Partials      228      229       +1     
Impacted Files Coverage Δ
service/config_provider.go 75.00% <ø> (-1.93%) ⬇️
service/collector.go 77.09% <100.00%> (-1.81%) ⬇️
service/servicetest/configprovider.go 76.00% <100.00%> (+22.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

service/collector.go Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 2f42fa1 into open-telemetry:main Oct 25, 2022
@bogdandrutu bogdandrutu deleted the servicetest branch October 25, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants