Fixed issue where telemetryInitializer is not cleaned up when newService errors #6239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.22% // Head: 92.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6239 +/- ##
=======================================
Coverage 92.22% 92.23%
=======================================
Files 219 219
Lines 13446 13456 +10
=======================================
+ Hits 12401 12411 +10
Misses 815 815
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
djaglowski
reviewed
Oct 6, 2022
Aneurysm9
approved these changes
Oct 6, 2022
mx-psi
approved these changes
Oct 7, 2022
bogdandrutu
reviewed
Oct 7, 2022
added 7 commits
October 7, 2022 12:42
…ice errors Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
…gs cleaner Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
cpheps
force-pushed
the
fix-telemetry-no-cleanup-on-error
branch
from
67d4813 to
fc3ffdf
Compare
|
@bogdandrutu made the suggested changes |
bogdandrutu
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: <Describe what has changed.
Fixing a bug - Fixed issue where the
telemetryInitializerwas not cleaned up ifnewServiceerrors aftertelemetryInitializer.initis called. This would cause subsequent calls to new service to error ontelemetryInitializer.init.Fixes: #6238
Testing: