Add options to confmap Marshal/Unmarshal, deprecate UnmarshalExact #6231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Oct 4, 2022
bogdandrutu
changed the title
Codecov ReportBase: 92.22% // Head: 92.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6231 +/- ##
==========================================
- Coverage 92.22% 92.21% -0.01%
==========================================
Files 219 219
Lines 13446 13456 +10
==========================================
+ Hits 12401 12409 +8
- Misses 815 817 +2
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/cc @djaglowski |
bogdandrutu
force-pushed
the
confmapopt
branch
3 times, most recently
from
4417d70 to
69ff475
Compare
dmitryax
reviewed
Oct 7, 2022
Officially this can be considered breaking change because of a use in a `var foo func(interface{}) error = conf.Unmarshal`, not in a normal calling usage, but this is an edgecase that we can except and move forward with this.
Signed-off-by: Bogdan <[email protected]>
bogdandrutu
force-pushed
the
confmapopt
branch
from
69ff475 to
6b8589e
Compare
dmitryax
approved these changes
Oct 7, 2022
codeboten
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Officially this can be considered breaking change because of a use in a
var foo func(interface{}) error = conf.Unmarshal, not in a normal calling usage, but this is an edgecase that we can except and move forward with this.This will allow to add more options to Marshal/Unmarshal in the future.