Add prometheus metric prefix and constant service attributes to otel-go prometheus exporter #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2022
bogdandrutu
reviewed
Oct 3, 2022
bogdandrutu
reviewed
Oct 3, 2022
Codecov ReportBase: 92.19% // Head: 92.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6223 +/- ##
==========================================
- Coverage 92.19% 92.17% -0.02%
==========================================
Files 219 219
Lines 13475 13488 +13
==========================================
+ Hits 12423 12433 +10
- Misses 823 825 +2
- Partials 229 230 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
paivagustavo
force-pushed
the
wrap-otel-go-prometheus-registry
branch
from
1761697 to
4121258
Compare
bogdandrutu
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This wraps
prometheus.Registrywith theotelcol_prefix and theservice_attributes as these are not supported directly by the OpenTelemetry Go Prometheus Exporter.This ensures that metrics exported by otel-go is consistent with the existing opencensus metrics.
Link to tracking Issue: #5882
Testing: Manual tested by adding a otel-go metric and testing this.