[confmap] Add mapstructure hook function for unmarshalling confmap.Conf #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.99% // Head: 92.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6029 +/- ##
==========================================
+ Coverage 91.99% 92.01% +0.01%
==========================================
Files 213 213
Lines 13340 13333 -7
==========================================
- Hits 12272 12268 -4
+ Misses 850 846 -4
- Partials 218 219 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
djaglowski
force-pushed
the
confmap-unmarshallable
branch
2 times, most recently
from
fc7460e to
25a8413
Compare
bogdandrutu
reviewed
Sep 6, 2022
djaglowski
force-pushed
the
confmap-unmarshallable
branch
4 times, most recently
from
bd45155 to
71cca53
Compare
This allows structs to implement custom unmarshaling behaviors when being unmarshaled from confmap.Conf.
djaglowski
force-pushed
the
confmap-unmarshallable
branch
from
71cca53 to
233c74d
Compare
bogdandrutu
approved these changes
Sep 8, 2022
bogdandrutu
reviewed
Sep 9, 2022
djaglowski
force-pushed
the
confmap-unmarshallable
branch
from
600275f to
de697ef
Compare
bogdandrutu
approved these changes
Sep 9, 2022
|
Contrib tests should pass once open-telemetry/opentelemetry-collector-contrib#14011 (review) is merged |
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves the Unmarshallable interface from
configtoconfmapin order to avoidan import cycle. This makes some sense anyways because the interface is concerned
specifically with unmarshalling a confmap.Conf. The config.Unmarshallable interface
is deprecated and changed to an alias of confmap.Unmarshallable.
Rehash of #4879