-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unmarshal Logs with jsoniter #6021
Implement unmarshal Logs with jsoniter #6021
Conversation
Codecov ReportBase: 92.01% // Head: 92.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6021 +/- ##
==========================================
+ Coverage 92.01% 92.07% +0.06%
==========================================
Files 213 213
Lines 13232 13322 +90
==========================================
+ Hits 12175 12266 +91
Misses 838 838
+ Partials 219 218 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
c0642bd
to
80fc04e
Compare
return lr | ||
} | ||
|
||
func (d *jsonUnmarshaler) readSeverityNumber(iter *jsoniter.Iterator) otlplogs.SeverityNumber { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary func called once.
Description:
Now Traces And Metrics was converted to jsoniter
, But Logs still uses
jsonpb. Unmarshaler with
jsoniter` will skip unknown fields instead of errorLink to tracking Issue: [https://github.com//pull/4986 ]
Testing:
unit test. construct a logs message, fill all the fields, use jsonpb marshal to json bytes, use jsoniter unmarshal to struct, test assert there are equal.