Change MetricDataPointFlags to the new immutable pattern #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
flagsimmutable
branch
from
d57e097 to
ea882cc
Compare
Codecov ReportBase: 92.15% // Head: 92.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5999 +/- ##
==========================================
- Coverage 92.15% 92.11% -0.05%
==========================================
Files 211 212 +1
Lines 13252 13278 +26
==========================================
+ Hits 12213 12231 +18
- Misses 822 830 +8
Partials 217 217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Aug 30, 2022
|
Can you PTAL at failing contrib tests. They look related |
|
@dmitryax they are caused by #5996, and will be fixed by open-telemetry/opentelemetry-collector-contrib#13738 |
TylerHelmuth
approved these changes
Aug 30, 2022
Signed-off-by: Bogdan <[email protected]>
bogdandrutu
force-pushed
the
flagsimmutable
branch
from
ea882cc to
1e2062f
Compare
dmitryax
reviewed
Aug 30, 2022
dmitryax
reviewed
Aug 30, 2022
dmitryax
approved these changes
Aug 30, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan [email protected]