Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loggingexporter] Rename labels to attributes #5977

Merged

Conversation

pirgeo
Copy link
Member

@pirgeo pirgeo commented Aug 26, 2022

Description:
While working on #5976, I realized that there are some leftover mentions of labels in the logging exporter code, and replaced them with attributes.

@pirgeo pirgeo requested review from a team and bogdandrutu August 26, 2022 08:49
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #5977 (7740597) into main (25192af) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5977   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         212      212           
  Lines       13264    13264           
=======================================
  Hits        12236    12236           
  Misses        811      811           
  Partials      217      217           
Impacted Files Coverage Δ
...er/loggingexporter/internal/otlptext/databuffer.go 99.12% <100.00%> (ø)
exporter/loggingexporter/internal/otlptext/logs.go 100.00% <100.00%> (ø)
...orter/loggingexporter/internal/otlptext/metrics.go 100.00% <100.00%> (ø)
...porter/loggingexporter/internal/otlptext/traces.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left 1 nit

CHANGELOG.md Outdated Show resolved Hide resolved
@pirgeo pirgeo force-pushed the rename-labels-attributes branch from eb4eda3 to 412e403 Compare August 26, 2022 15:59
@pirgeo
Copy link
Member Author

pirgeo commented Aug 26, 2022

I pushed it again without the changelog commits! Thanks for taking a look 🙂

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants