[pdata] Deprecate map.Upsert/Update #5975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.14% // Head: 92.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5975 +/- ##
==========================================
+ Coverage 92.14% 92.16% +0.01%
==========================================
Files 210 210
Lines 13235 13266 +31
==========================================
+ Hits 12196 12227 +31
Misses 822 822
Partials 217 217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
reviewed
Aug 26, 2022
dmitryax
force-pushed
the
deprecate-upsert
branch
3 times, most recently
from
47b4ce7 to
38c74ea
Compare
bogdandrutu
reviewed
Aug 26, 2022
dmitryax
force-pushed
the
deprecate-upsert
branch
from
38c74ea to
c706ada
Compare
dmitryax
force-pushed
the
deprecate-upsert
branch
from
c706ada to
7471208
Compare
dmitryax
force-pushed
the
deprecate-upsert
branch
from
7471208 to
358cd50
Compare
dmitryax
force-pushed
the
deprecate-upsert
branch
2 times, most recently
from
251aa01 to
3f8ca9b
Compare
bogdandrutu
approved these changes
Aug 28, 2022
dmitryax
force-pushed
the
deprecate-upsert
branch
from
3f8ca9b to
3becb11
Compare
dmitryax
force-pushed
the
deprecate-upsert
branch
from
3becb11 to
b3c473c
Compare
bogdandrutu
approved these changes
Aug 29, 2022
bogdandrutu
changed the title
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcommon.Map.Insert/Update/Upsertmethods are the only methods allowing setting the mutable types on the Map. This goes against the established practice of building pdata.This PR add extra methods to
pcommon.Valueandpcommon.Mapto replacepcommon.Map.Insert/Update/Upsertmethods. Deprecation ofpcommon.Map.Insertis delayed since they are used in many places in contrib. So we want to replaces them first.Updates: #5974 and #5973