Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New immutable type for Flags structs #5970

Closed

Conversation

bogdandrutu
Copy link
Member

PR will fail the "Check" stage since I manually change the generated code.

Signed-off-by: Bogdan [email protected]

@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan August 25, 2022 22:57
@bogdandrutu bogdandrutu marked this pull request as draft August 25, 2022 22:57
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #5970 (2a73ea0) into main (7545a29) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5970      +/-   ##
==========================================
- Coverage   92.30%   92.26%   -0.05%     
==========================================
  Files         212      214       +2     
  Lines       13263    13269       +6     
==========================================
- Hits        12243    12242       -1     
- Misses        803      810       +7     
  Partials      217      217              
Impacted Files Coverage Δ
pdata/plog/logs.go 83.87% <ø> (-6.52%) ⬇️
pdata/pcommon/trace_flags.go 100.00% <100.00%> (ø)
pdata/plog/generated_logs.go 96.79% <100.00%> (+0.02%) ⬆️
pdata/plog/log_record_flags.go 100.00% <100.00%> (ø)
pdata/internal/wrapper_logs.go 69.56% <0.00%> (-30.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bogdandrutu
Copy link
Member Author

Dropping this in favor of the simpler API in #5972, still if interested review this to understand the logic.

@bogdandrutu bogdandrutu deleted the flagsalternative branch October 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant