Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark custom distribution flags as deprecated #5946

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan [email protected]

@bogdandrutu bogdandrutu marked this pull request as ready for review August 22, 2022 17:42
@bogdandrutu bogdandrutu requested review from a team and codeboten August 22, 2022 17:42
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #5946 (83c9ce2) into main (058c13d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5946   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files         200      200           
  Lines       12410    12410           
=======================================
  Hits        11410    11410           
  Misses        789      789           
  Partials      211      211           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left one non-critical question.

cmd/builder/internal/command.go Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 07de5b2 into open-telemetry:main Aug 22, 2022
@bogdandrutu bogdandrutu deleted the deprecatecustomtags branch August 22, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants