Change pdata generated types to use type definition instead of aliases

[bogdandrutu]

Change the way how objects are generated in pdata. Previously the pdata objects were generated in the internal package and aliases were created in the public packageas.

This PR changes this, by creating only "wrappers" object inside the internal package, and the public type is a type def of the internal type:

package internal

type LogRecord struct {
	orig *otlplogs.LogRecord
}

func GetOrigLogRecord(ms LogRecord) *otlplogs.LogRecord {
	return ms.orig
}

func NewLogRecord(orig *otlplogs.LogRecord) LogRecord {
	return LogRecord{orig: orig}
}

package plog

type LogRecord internal.LogRecord

With this approach, we still do not allow users access to the internal origin, which allows us flexibility to change to other representation (something like lazy proto, etc), but improves documentation of the pdata packages, see current documentation.

Signed-off-by: Bogdan [email protected]

[codecov]

Codecov Report

Merging #5936 (474d968) into main (18700db) will increase coverage by 0.39%.
The diff coverage is 99.04%.

@@            Coverage Diff             @@
##             main    #5936      +/-   ##
==========================================
+ Coverage   91.90%   92.30%   +0.39%     
==========================================
  Files         200      212      +12     
  Lines       12414    13249     +835     
==========================================
+ Hits        11409    12229     +820     
- Misses        793      803      +10     
- Partials      212      217       +5     

Impacted Files	Coverage Δ
pdata/pcommon/timestamp.go	100.00% <ø> (ø)
pdata/ptrace/json.go	100.00% <ø> (ø)
pdata/ptrace/pb.go	100.00% <ø> (ø)
pdata/ptrace/ptraceotlp/traces.go	49.01% <ø> (ø)
pdata/ptrace/traces.go	92.59% <ø> (ø)
pdata/plog/logs.go	90.38% <92.30%> (ø)
pdata/plog/generated_logs.go	96.77% <97.69%> (ø)
pdata/ptrace/generated_traces.go	97.02% <97.87%> (ø)
pdata/pmetric/generated_metrics.go	96.08% <98.31%> (ø)
pdata/internal/generated_wrapper_common.go	100.00% <100.00%> (ø)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dmitryax]

Just couple of nits. Otherwise LGTM.

This is a great solution! I believe the only downside is that now we have some computational overhead spent of type conversions, right?

[bogdandrutu]

This is a great solution! I believe the only downside is that now we have some computational overhead spent of type conversions, right?

I believe the compiler should be smart enough to not have to do this :)

[dmitryax]

LGTM