Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata/plog] Rename severity number constant #5927

Merged

Conversation

dmitryax
Copy link
Member

Do not use uppercase in severity number constants for consistency with other pdata constants. Old constants are deprecated.

Resolves #5867

@dmitryax dmitryax requested review from a team and mx-psi August 17, 2022 05:45
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #5927 (e77f20e) into main (8cb6af9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5927   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files         197      197           
  Lines       12377    12377           
=======================================
  Hits        11363    11363           
  Misses        800      800           
  Partials      214      214           
Impacted Files Coverage Δ
pdata/internal/logs.go 91.07% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Do not use uppercase in severity number constants for consistency with other pdata constants. Old constants are deprecated.
@dmitryax dmitryax force-pushed the update-log-severity-numbers branch from d8beb25 to e77f20e Compare August 17, 2022 07:35
@tigrannajaryan tigrannajaryan merged commit e0adb9d into open-telemetry:main Aug 17, 2022
@dmitryax dmitryax deleted the update-log-severity-numbers branch August 17, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plog.SeverityNumber enum values inconsistent with others
5 participants