Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add missing dashes to descriptions of flags #5812

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

aboguszewski-sumo
Copy link
Member

Description:
A small fix to the descriptions of flags. In their descriptions, config and set flags had examples that used only one dash before the flag instead of two, which was a bit misleading.

@aboguszewski-sumo aboguszewski-sumo requested review from a team and mx-psi August 4, 2022 13:08
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #5812 (8a7a2ad) into main (d146f29) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5812   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         192      192           
  Lines       11470    11470           
=======================================
  Hits        10502    10502           
  Misses        773      773           
  Partials      195      195           
Impacted Files Coverage Δ
service/flags.go 88.46% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Config and set flags had misleading descriptions that contained examples with one dash before the flag instead of two.
@aboguszewski-sumo aboguszewski-sumo changed the title Add missing dashes to descriptions of flags [chore] Add missing dashes to descriptions of flags Aug 4, 2022
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants