-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/logging] Add syscall.EBADF
to list of known sync errors
#5585
[exporter/logging] Add syscall.EBADF
to list of known sync errors
#5585
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5585 +/- ##
==========================================
- Coverage 91.27% 91.24% -0.04%
==========================================
Files 191 191
Lines 11304 11308 +4
==========================================
Hits 10318 10318
- Misses 785 789 +4
Partials 201 201
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a performance impact to run through a loop versus the hard-coded OR statement?
@TylerHelmuth AIUI this is only called here
|
In that case I would agree. |
Description: Adds
syscall.EBADF
('bad file descriptor') to the list of known sync errors.Link to tracking Issue: Fixes #4153
Testing: I tested that this fixes the test skipped in DataDog/datadog-agent#12502