Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version from BuildInfo everywhere in service, remove internal/version #5449

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan June 1, 2022 00:42
@bogdandrutu
Copy link
Member Author

/cc @mx-psi you raised this issue in one of @tigrannajaryan PRs. Also for @tigrannajaryan this fixes the problem that we always had "latest" in the metrics since the binaries that we produce none of them set this internal/version.Version, only set in this Makefile.

@mx-psi
Copy link
Member

mx-psi commented Jun 1, 2022

You need to run make goporto:

porto -w --include-internal ./
diff --git a/service/internal/runtimeinfo/info.go b/service/internal/runtimeinfo/info.go
index 976bbdc..7a6b4d7 100644
--- a/service/internal/runtimeinfo/info.go
+++ b/service/internal/runtimeinfo/info.go
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package runtimeinfo // import "go.opentelemetry.io/collector/internal/runtimeinfo"
+package runtimeinfo // import "go.opentelemetry.io/collector/service/internal/runtimeinfo"

There was also a data race on the unit tests with the gRPC logger (probably not related to this PR?)

@bogdandrutu bogdandrutu merged commit c5f118e into open-telemetry:main Jun 1, 2022
@bogdandrutu bogdandrutu deleted the usebuildinfo branch June 1, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants