Setup the correct meter provider if telemetry.useOtelForInternalMetrics featuregate enabled #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5146 +/- ##
==========================================
- Coverage 90.33% 90.30% -0.03%
==========================================
Files 182 182
Lines 11032 11031 -1
==========================================
- Hits 9966 9962 -4
- Misses 841 843 +2
- Partials 225 226 +1
Continue to review full report at Codecov.
|
Aneurysm9
approved these changes
Apr 4, 2022
…cs featuregate enabled This PR also removes the set of the global MeterProvider, similarly with open-telemetry#5138. Signed-off-by: Bogdan Drutu <[email protected]>
codeboten
approved these changes
Apr 4, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…cs featuregate enabled (open-telemetry#5146) This PR also removes the set of the global MeterProvider, similarly with open-telemetry#5138. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes the set of the global MeterProvider, similarly with #5138.
Signed-off-by: Bogdan Drutu [email protected]