-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP/2 with TLS in OTLP HTTP receiver. #5109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5109 +/- ##
==========================================
- Coverage 89.96% 89.94% -0.03%
==========================================
Files 183 182 -1
Lines 11104 11081 -23
==========================================
- Hits 9990 9967 -23
Misses 889 889
Partials 225 225
Continue to review full report at Codecov.
|
anuraaga
force-pushed
the
otlp-http2
branch
2 times, most recently
from
March 29, 2022 07:24
5232d60
to
7523cb1
Compare
mx-psi
reviewed
Mar 29, 2022
Closing/opening to trigger github actions... |
mx-psi
approved these changes
Mar 31, 2022
jpkrohling
approved these changes
Apr 1, 2022
bogdandrutu
approved these changes
Apr 1, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
* Support HTTP/2 with TLS in OTLP HTTP receiver. * Add benchmark * Explicit http/1 fallback proto * Update CHANGELOG.md Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the HTTP receiver never negotiates HTTP/2 even when the client supports it. In a typical scenario of having many apps with batch exporters hitting a collector, HTTP/1 and HTTP/2 should perform mostly the same, but if putting a load balancer in front of the collector, HTTP/2 will be able to multiplex many apps across a single connection and can perform quite a bit better.
Benchmarks are noisy since executing actual HTTP requests. Hopefully we can see some trends
HTTP/2 seems to provide about 3x performance when using a shared client (behaves like a load balancer)
HTTP/2 performs slightly slower with a client per thread (behaves like an app), but this is probably within noise. It is something to confirm we're OK with - I think most services now adays will support HTTP/2 though even if it can be slightly slower in non-shared cases. One way to think of it is gRPC is HTTP/2-only anyways and we'd expect HTTP receiver to have a similar baseline.
After
Before (HTTP/2 is actually 1.1)