[pdata] Rename ValueTypeArray to ValueTypeSlice #5066
Conversation
`pdata.ValueTypeArray` is not deprecated because it was introduced few commits before and not released yet.
Codecov Report
@@ Coverage Diff @@
## main #5066 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 180 180
Lines 10814 10814
=======================================
Hits 9846 9846
Misses 749 749
Partials 219 219
Continue to review full report at Codecov.
|
| func TestAttributeValueArray(t *testing.T) { | ||
| a1 := NewValueArray() | ||
| assert.EqualValues(t, ValueTypeArray, a1.Type()) | ||
| func TestAttributeValueSlice(t *testing.T) { |
There was a problem hiding this comment.
Separate PR consider to remove Attribute from test names.
|
Please rebase |
|
done |
|
contrib-tests / contrib_tests is failing because of removed |
I think that's correct. We don't have any releases with that identifier so there is no need to perpetuate it for compatibility. |
Follow up to open-telemetry/opentelemetry-collector#5066: Rename `Array` type of `pdata.Value` to `Slice` - Deprecate `pdata.AttributeValueTypeArray` type in favor of `pdata.ValueTypeSlice` - Deprecate `pdata.NewAttributeValueArray` func in favor of `pdata.NewValueSlice`
* update otel core Follow up to open-telemetry/opentelemetry-collector#5066: Rename `Array` type of `pdata.Value` to `Slice` - Deprecate `pdata.AttributeValueTypeArray` type in favor of `pdata.ValueTypeSlice` - Deprecate `pdata.NewAttributeValueArray` func in favor of `pdata.NewValueSlice` * fix lint
* [pdata] Rename ValueTypeArray to ValueTypeSlice `pdata.ValueTypeArray` is not deprecated because it was introduced few commits before and not released yet. * Update CHANGELOG.md
pdata.ValueTypeArrayis removed without deprecation because it was introduced few commits before and not released yet.Closes: #5065