Collector Run will listen for context done

[cpheps]

Description:
Fixes #4842

Added listening for <-ctx.Done() in Run select so if the passed in context cancels the collector will too.

There was a weird pattern though where internal shutdown takes a context and currently it's the passed in one. For the case of context cancelling I called the shutdown function with background context. Wondering if we want to put a timer on this or if we want to always use background context on shutdown. I could see a scenario where the collector is shutting down and the passed in context is canceled and interrupts the graceful shutdown.

Link to tracking Issue: #4842

Testing: Added unit test

[codecov]

Codecov Report

Merging #4954 (eb8f911) into main (c257aba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4954   +/-   ##
=======================================
  Coverage   91.03%   91.04%           
=======================================
  Files         178      178           
  Lines       10613    10617    +4     
=======================================
+ Hits         9662     9666    +4     
  Misses        734      734           
  Partials      217      217           

Impacted Files	Coverage Δ
service/collector.go	77.43% <100.00%> (+0.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c257aba...eb8f911. Read the comment docs.

[bogdandrutu]

I am confused if we need Shutdown at all at this point. I think this is a good change, but would like to think about.

[cpheps]

I am confused if we need Shutdown at all at this point. I think this is a good change, but would like to think about.

I think it's still useful to have Shutdown. Since the collector is likely the core thing being run in a binary containing it I would think most use cases for context would be from signal intercepts. If you didn't want to intercept signals Shutdown provides a clear way to stop the collector. I think using context or Shutdown achieve the same behavior but calling Shutdown is more deliberate on the part of the wrapper code.