Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote @mx-psi as approver #4927

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Promote @mx-psi as approver #4927

merged 1 commit into from
Feb 28, 2022

Conversation

bogdandrutu
Copy link
Member

Fixes #2819

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and codeboten February 28, 2022 16:47
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 28, 2022
codeboten
codeboten approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bogdandrutu
Copy link
Member Author

/cc @mx-psi

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #4927 (15fd0b5) into main (4998703) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4927   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files         180      180           
  Lines       10622    10622           
=======================================
  Hits         9651     9651           
  Misses        755      755           
  Partials      216      216

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4998703...15fd0b5. Read the comment docs.

@mx-psi
Copy link
Member

mx-psi commented Feb 28, 2022

Thanks :) 🎉

@bogdandrutu bogdandrutu merged commit 14b44ac into open-telemetry:main Feb 28, 2022
@bogdandrutu bogdandrutu deleted the mxpsi branch February 28, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track @mx-psi interest and contributions for approver
5 participants
@bogdandrutu @mx-psi @jpkrohling @codeboten @tigrannajaryan