[Builder]: Remove test that depends on the contrib #4787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4787 +/- ##
=======================================
Coverage 90.82% 90.82%
=======================================
Files 181 181
Lines 10632 10632
=======================================
Hits 9657 9657
Misses 759 759
Partials 216 216 Continue to review full report at Codecov.
|
|
/cc @jpkrohling |
jpkrohling
reviewed
Feb 4, 2022
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
test2
branch
2 times, most recently
from
d1a36f8 to
c8072be
Compare
jpkrohling
approved these changes
Feb 15, 2022
bogdandrutu
force-pushed
the
test2
branch
2 times, most recently
from
0b19d20 to
1fcef17
Compare
The latest is tested by the cmd/otelcorecol which uses the builder to generate the files. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary test for replace since the
cmd/otelcorecoltests the latest binary with replace statements already.Signed-off-by: Bogdan Drutu [email protected]