Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent config member name with configuration keys #4363

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team, tigrannajaryan and jpkrohling and removed request for tigrannajaryan November 4, 2021 19:03
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #4363 (54ccca4) into main (9092332) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4363   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files         176      176           
  Lines       10378    10378           
=======================================
  Hits         9177     9177           
  Misses        971      971           
  Partials      230      230           
Impacted Files Coverage Δ
cmd/builder/internal/builder/config.go 45.71% <ø> (ø)
cmd/builder/internal/builder/main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9092332...54ccca4. Read the comment docs.

cmd/builder/cmd/root.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 484e315 into open-telemetry:main Nov 4, 2021
@bogdandrutu bogdandrutu deleted the configname branch November 4, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants