Rename OpenTelemetry Service to Collector in docs and comments #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
flands,
owais,
pjanotti and
songy23
as code owners
songy23
approved these changes
Sep 17, 2019
README.md
Outdated
| @@ -123,7 +123,7 @@ exporting will resume. | |||
|
|
|||
| ## <a name="config"></a>Configuration | |||
|
|
|||
| The OpenTelemetry Service (both the Agent and Collector) is configured via a | |||
| The OpenTelemetry Collector (both the Agent and Collector) is configured via a | |||
There was a problem hiding this comment.
Suggested change
| The OpenTelemetry Collector (both the Agent and Collector) is configured via a | |
| The OpenTelemetry Collector is configured via a |
There was a problem hiding this comment.
Fixed, thank you.
README.md
Outdated
| @@ -177,7 +177,7 @@ receivers: | |||
|
|
|||
| An exporter is how you send data to one or more backends/destinations. One or | |||
| more exporters can be configured. By default, no exporters are configured on | |||
| the OpenTelemetry Service (either the Agent or Collector). | |||
| the OpenTelemetry Collector (either the Agent or Collector). | |||
There was a problem hiding this comment.
Suggested change
| the OpenTelemetry Collector (either the Agent or Collector). | |
| the OpenTelemetry Collector. |
This begins implementation of open-telemetry#352
tigrannajaryan
force-pushed
the
feature/tigran/rename
branch
from
291e5d5 to
06e74e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
======================================
Coverage 74.4% 74.4%
======================================
Files 115 115
Lines 6708 6708
======================================
Hits 4991 4991
Misses 1470 1470
Partials 247 247
Continue to review full report at Codecov.
|
|
@owais @pjanotti @flands @bogdandrutu please review. |
owais
approved these changes
Sep 19, 2019
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Simplify Makefile In particular, this change: * Ensures that the race checker is always used for all tests * Removes redundant commands * Splits out `generate` and `lint` as their own commands * Renames the `circle-ci` command to the more generic `ci` * Use GOTEST_WITH_COVERAGE instead of old name * Fix test-with-coverage command * Fix test-386 command
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Adopt Range in integration tests * Update Smart Agent to 5.10.2
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Signed-off-by: birca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins implementation of #352