Changed usage of ApplicationStartInfo to BinaryInfo #3045
Conversation
| // passed into each component. This information can be overridden in custom builds. | ||
| type ApplicationStartInfo struct { | ||
| type BinaryInfo struct { |
There was a problem hiding this comment.
@Aneurysm9 what do you think about "BuildInfo" to be more in sync with golang debug.BuildInfo? Brainstorming so any ideas are welcome. Do we want to actually use the debug.BuildInfo.Path instead of description? That is something that we can get programmatically so may be better than Description?
There was a problem hiding this comment.
BuildInfo sounds good to me. I don't think that debug.BuldInfo.Path works for our present use case, but I can definitely see where having that identifier that uniquely identifies the package and can be programmatically inserted into the BuildInfo is useful. Someone may copypasta the BuildInfo definition from this repo and not update the description, but they wouldn't be able to avoid having the toolchain report the package path it was built from. I'll work with @dhruv-vora to get a follow-up issue/PR created for that.
|
Please rebase |
Description: