Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change health_check default endpoint to 0.0.0.0:13133 #2828

Merged

Conversation

dmitryax
Copy link
Member

This commits brings back default configuration of the health_check extension to make sure it works in k8s-like environments without extra configuration as it was before the latest change #2782.

Resolves: #2827

@dmitryax dmitryax requested a review from a team March 26, 2021 23:38
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #2828 (0b1d35f) into main (c4108c1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2828   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         281      281           
  Lines       15131    15131           
=======================================
  Hits        13886    13886           
  Misses        852      852           
  Partials      393      393           
Impacted Files Coverage Δ
extension/healthcheckextension/factory.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4108c1...0b1d35f. Read the comment docs.

This commits brings back default configuration of the health_check extension to make sure it works in k8s-like environments without extra configuration as it was before the latest change open-telemetry#2782.

Resolves: open-telemetry#2827
@dmitryax dmitryax force-pushed the change-health-check-default-endpoint branch from a7eecb0 to 0b1d35f Compare March 27, 2021 20:16
@bogdandrutu bogdandrutu merged commit 98bea6e into open-telemetry:main Mar 28, 2021
@dmitryax dmitryax deleted the change-health-check-default-endpoint branch March 28, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health check extension with default configuration doesn't work in k8s environment anymore
3 participants