New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom expression parsers for Resource and InstrumentationLibrary #2408

Closed

bogdandrutu wants to merge 1 commit into open-telemetry:main from bogdandrutu:filterexpr

Member

bogdandrutu commented Jan 26, 2021 •

edited

Loading

Benchmarks:

goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/internal/processor/filterexpr
BenchmarkEvaluateIls
BenchmarkEvaluateIls-16    	80174056	        12.8 ns/op	       0 B/op	       0 allocs/op
PASS

goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/internal/processor/filterexpr
BenchmarkEvaluateResource
BenchmarkEvaluateResource-16    	51025928	        21.2 ns/op	       0 B/op	       0 allocs/op
PASS

Tested with the current PropertiesMatcher and for Resource and InstrumentationLibraryInfo saw similar results.

Signed-off-by: Bogdan Drutu [email protected]

bogdandrutu requested a review from a team

January 26, 2021 17:40

codecov bot commented Jan 26, 2021 •

edited

Loading

Codecov Report

Merging #2408 (3502d5d) into master (602415d) will increase coverage by 0.08%.
The diff coverage is 98.03%.

@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
+ Coverage   91.92%   92.00%   +0.08%     
==========================================
  Files         270      276       +6     
  Lines       15311    15515     +204     
==========================================
+ Hits        14075    14275     +200     
- Misses        857      859       +2     
- Partials      379      381       +2

Impacted Files	Coverage Δ
internal/processor/filterexpr/il_parser.go	`96.87% <96.87%> (ø)`
internal/processor/filterexpr/resource_parser.go	`97.01% <97.01%> (ø)`
internal/processor/filterexpr/attr_expr.go	`100.00% <100.00%> (ø)`
internal/processor/filterexpr/il_expr.go	`100.00% <100.00%> (ø)`
internal/processor/filterexpr/primitive_expr.go	`100.00% <100.00%> (ø)`
internal/processor/filterexpr/resource_expr.go	`100.00% <100.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602415d...3502d5d. Read the comment docs.

bogdandrutu force-pushed the filterexpr branch 2 times, most recently from f6f559a to ff7c24b Compare

January 26, 2021 20:02


          Add custom expression parsers for Resource and InstrumentationLibrary

3502d5d

Signed-off-by: Bogdan Drutu <[email protected]>

bogdandrutu force-pushed the filterexpr branch from ff7c24b to 3502d5d Compare

January 26, 2021 20:39

Base automatically changed from master to main

January 28, 2021 18:06

Contributor

github-actions bot commented Feb 5, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Feb 14, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Feb 28, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Mar 9, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

jrcamp mentioned this pull request

Extending Attributes processor #1170

Closed

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Mar 18, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

Contributor

github-actions bot commented Mar 26, 2021

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions bot closed this

bogdandrutu mentioned this pull request

Evaluate antonmedv/expr for use in filters and transforms open-telemetry/opentelemetry-collector-contrib#5887

Closed

bogdandrutu deleted the filterexpr branch

February 1, 2022 02:31

spencerwilson mentioned this pull request

A Sampling Configuration proposal open-telemetry/oteps#240

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels