-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change host metrics receiver to use the new metrics internal structs #1682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1682 +/- ##
========================================
Coverage 92.28% 92.29%
========================================
Files 265 265
Lines 19818 19928 +110
========================================
+ Hits 18290 18393 +103
- Misses 1099 1105 +6
- Partials 429 430 +1
Continue to review full report at Codecov.
|
receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/filesystem_metadata.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_metadata.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/networkscraper/network_metadata.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processesscraper/processes_metadata.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processesscraper/processes_metadata.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_metadata.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_metadata.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/swapscraper/swap_metadata.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm - ignore all my previous comments.
The distinction between a Gauge and a non-monotomic Cumulative is:
- A Cumulative can be used in any case where measurements are added: e.g. when data is written to disk, +some bytes, when data is deleted from disk, -some bytes
- A Gauge is reserved for cases where the data source is not a sum or is not known, e.g. CPU Load (which is a moving average)
With that context, this all looks good.
receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/filesystem_metadata.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Bogdan Drutu <[email protected]>
* initial version of the pulsar exporter (metrics). Tests yet to be added. (open-telemetry#1541) authored-by: Shiva Param <[email protected]> authored-by: Narasimha Rao <[email protected]> authored-by: narasimharaojm <[email protected]> * pulsarexporter: fix lint, remove failing tests (open-telemetry#1682) This is an experimental component added by PayPal. Unit tests to be added later.
The most important changes are in the metadata files, others are just simple renaming.
Updates #1657
Depends on #1684 which adds the SetDataType and adds tests for it.