Pass version (& other app info) into components in params struct #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
|
|
||
| // ApplicationStartInfo is the information that is logged at the application start and | ||
| // passed into each component. This information can be overridden in custom builds. | ||
| type ApplicationStartInfo struct { |
There was a problem hiding this comment.
If we are passing this info into each component, I thought it makes sense to move the struct here. Technically this is a breaking change, but very minor
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
==========================================
+ Coverage 91.86% 91.90% +0.03%
==========================================
Files 254 255 +1
Lines 17486 17510 +24
==========================================
+ Hits 16064 16092 +28
+ Misses 1014 1012 -2
+ Partials 408 406 -2
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
version-in-components
branch
from
da7c2fb to
e786184
Compare
james-bebbington
changed the title
james-bebbington
force-pushed
the
version-in-components
branch
from
e786184 to
6293232
Compare
bogdandrutu
reviewed
Aug 20, 2020
james-bebbington
force-pushed
the
version-in-components
branch
2 times, most recently
from
5e0b62a to
f7ee02d
Compare
nilebox
approved these changes
Aug 21, 2020
|
Please rebase |
james-bebbington
force-pushed
the
version-in-components
branch
from
a509543 to
5358f1d
Compare
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: #1559
Update service pipeline to pass ApplicationInfo into all new components as part of the
CreateParamsstructs.Example Usage: open-telemetry/opentelemetry-collector-contrib#758